Compatibility Fix: Do not load translations early #9940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
6 tasks
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
RadoslavGeorgiev
changed the base branch from
develop
to
add/jetpack-config-callback
The core payment gateway class only uses the `method_description` property within `get_method_description()`, a method that we are already overloading. This makes the `$this->method_description = $this->get_method_description()` call redundant, especially in the constructor.
RadoslavGeorgiev
changed the title
zmaglica
approved these changes
Dec 13, 2024
mordeth
approved these changes
Dec 13, 2024
mgascam
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Code changes look good to me and I love the approach. I tested setting the language to Spanish and everything works well. Also, no more instances of Translation loading for the <code>woocommerce-payments</code> domain was triggered too early. in the logs with this branch. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9727
Changes proposed in this Pull Request
Based on #9884, to avoid also seeing Jetpack initialization warnings.
This PR is an alternative approach to @mordeth's idea to shuffle initialization, #9872. However, instead of re-ordering the whole initialization project, which seems a bit risky, this PR focuses on only loading translations at the right time.
Testing instructions
woocommerce-paymentstranslations being loaded too early._load_textdomain_just_in_timewas called incorrectly." warnings, but they should not be related to thewoocommerce-paymentsdomain.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge