Improve message shown to merchants when there is an error capturing/cancelling pending authorizations #9937
+221
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.57 kB (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
…e-shown-to-merchants-when-there-is-an-error-capturing-authorizations
…e-shown-to-merchants-when-there-is-an-error-capturing-authorizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5002
Changes proposed in this Pull Request
This pull request includes changes to improve error handling in the
submitCaptureAuthorizationandsubmitCancelAuthorizationfunctions and adds corresponding tests. The most important changes include refactoring error handling to provide more detailed error messages and adding tests to ensure proper error handling behavior.Testing instructions
WP Admin>Payments>Settings>Issue an authorization on checkout, and capture laterwoocommerce-payments/includes/admin/class-wc-rest-payments-orders-controller.php
Line 267 in d43e033
woocommerce-payments/includes/admin/class-wc-rest-payments-orders-controller.php
Line 493 in d43e033
return new WP_Error( 'wcpay_missing_order', __( 'This is a test error', 'woocommerce-payments' ), [ 'status' => 404 ] );You can also test the cancel flow similarly but you must reveal the
Block transactionbutton. You can apply this tweak:npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge