-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove tokeinzed payment request code #9920
chore: remove tokeinzed payment request code #9920
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
Waiting on #9877 |
8d4edb8
to
a1bc1de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to make test purchases with Google Pay ECE in Checkout, Cart, and Product Details, so it seems there are no unintended side effects.
I also wasn't able to find any more outstanding references to the old PRB implementation.
Fixes #9722
Changes proposed in this Pull Request
Final part of #9722
Deleting any code related to the old "Tokenized PRBs".
This includes:
client/tokenized-payment-request
directory (its files are not even bundled by Webpack anymore)includes/class-wc-payments-payment-request-button-handler.php
file (and its tests - which are not included anywhere anymore)Testing instructions
Not much to test here, just deleting code that isn't included anywhere.
Code-wise - there shouldn't be any more references to the "Tokenized PRBs" (but "Tokenized ECE" should stay).
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge