Fixed UPE country detection in Checkout for non-logged in users #9912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
timur27
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks @gpressutto5, I could reproduce it prior to #9782.
The change is clear and makes sense, the only thing is we might want to double-check whether we want to hide all the payment methods if the billing country is not set (like we're doing with your change), or we show all of them instead. I think your approach is safer, because it protects against situation when someone uses a payment method which is ultimately not supported in their country.
This logic has not changed with my PR. It was already in the code, but it was broken because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
When there's no country selected in the checkout we try to get it from
wcpayCustomerDatawhich is unavailable, causing an error and displaying Klarna and Afterpay as an option when they shouldn't be displayed. This PR fixes that by usingwindow?.wcpayCustomerData.Testing instructions
develop: See Afterpay and Klarna are displayed and there's an error in the console.fix-upe-country-selection: Afterpay and Klarna are not displayed and there's no error in the console.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge