Reports: Update Transaction ID column label #9911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
jessy-p
reviewed
Dec 11, 2024
@jessy-p - IIRC there is an issue logged at the core component level. It gets clipped currently. It may be related to that. The capitalized Update- I checked and it does not seem to be doing on my browser 🤔 . Can you share an output from whatismybrowser.com ? Also if you can check if there is any browser zoom enabled? Thanks |
|
Adding Helix back as a reviewer for some more reviews to see if the warping mentioned by @jessy-p is visible elsewhere. If it exists with other reviewers, It will be worth checking if the issue gets resolved by woocommerce/woocommerce#53066 |
haszari
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Code changes are zero risk and awesome, ID is definitely the right spelling 😁
Tested and I did not see any new wrapping - looks just as good as before:
The positioning and size of the menu is not ideal (as before):
- Menu is clipped by edge of browser
- Some items wrap
But that's a totally different issue!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9910
Changes proposed in this Pull Request
Change column name
Transaction IdtoTransaction IDfor consistency with how unique ID's are labelled across the UI.Testing instructions
Transaction IDinstead ofTransaction Id. Toggle that control onTransaction IDnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge