Remove temporary transaction table search field CSS that was used for Payment Activity Card report filtering #9881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This filter is already available on server.
…ttic/woocommerce-payments into fix/use-type-is-in-filter
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -352 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
…y-transaction-search-css
…y-transaction-search-css
…y-transaction-search-css
shendy-a8c
approved these changes
Dec 8, 2024
…y-transaction-search-css
Jinksi
deleted the
fix/9736-remove-temporary-payment-activity-transaction-search-css
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9736
Changes proposed in this Pull Request
#8996 has introduced a temporary CSS fix used to improve the transaction table search field UX when many search terms were active. This occurred when clicking through from a Payment Activity Card report (currently unreleased).
This also inadvertently impacted the Payouts list styles (issue #9736) by misaligning the "Download" button to the left of the table header, inconsistent with other list view tables (Transactions, Disputes).
PR #9871 negates the need for this CSS by using a method other than search bar terms for filtering Payment Activity Card reports.
This PR removes these CSS, resolving the Payouts list "Download" button styling issue and removing dead code that no longer needs to be maintained.
Payouts:
Transactions:
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge