Rename 'Deposit' to 'Payout' (feature branch) #9606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nagesh Pai <[email protected]>
shendy-a8c
added
the
status: blocked
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6.64 kB (+1%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Co-authored-by: Rua Haszard <[email protected]> Co-authored-by: Shendy <[email protected]>
Co-authored-by: Rua Haszard <[email protected]> Co-authored-by: Nagesh Pai <[email protected]> Co-authored-by: Shendy <[email protected]>
haszari
changed the title
…#9565) Co-authored-by: Nagesh Pai <[email protected]>
Co-authored-by: Jessy <[email protected]>
Co-authored-by: Jessy <[email protected]>
Co-authored-by: Jessy <[email protected]> Co-authored-by: Shendy <[email protected]>
Co-authored-by: Jessy <[email protected]>
Co-authored-by: Jessy <[email protected]>
# Conflicts: # client/deposits/instant-payouts/index.tsx
The PR is a part of a larger project renaming `deposit` to `payout` across the WooPayments plugin UI. Co-authored-by: Nagesh Pai <[email protected]>
Co-authored-by: Nagesh Pai <[email protected]>
Co-authored-by: Nagesh Pai <[email protected]>
Co-authored-by: Nagesh Pai <[email protected]> Co-authored-by: Eric Jinks <[email protected]>
|
I see that we will have multiple changelog entries for this feature branch. IMO, we should just boil it down to just one changelog entry. What do you think @nagpai? Maybe something generic like: Rename 'deposit' to 'payout'. |
shendy-a8c
commented
Nov 8, 2024
Comment on lines
3
to
4
|
|
||
| Payouts rename: Settings page, part of a larger change |
There was a problem hiding this comment.
Suggested change
| Payouts rename: Settings page, part of a larger change | |
| Comment: Payouts rename: Settings page, part of a larger change | |
There was a problem hiding this comment.
Thanks! Changed here - 80cae5a
shendy-a8c
commented
Nov 8, 2024
Comment on lines
1
to
4
| Significance: minor | ||
| Type: update | ||
|
|
||
| Rename 'deposit' to 'payout' across various places in the WooPayments admin UI. |
There was a problem hiding this comment.
To make this changelog file not to create a changelog entry:
Suggested change
| Significance: minor | |
| Type: update | |
| Rename 'deposit' to 'payout' across various places in the WooPayments admin UI. | |
| Significance: patch | |
| Type: dev | |
| Comment: Rename 'deposit' to 'payout' across various places in the WooPayments admin UI. | |
There was a problem hiding this comment.
This is the main changelog for the PR and should be probably kept as it is?
shendy-a8c
commented
Nov 8, 2024
Comment on lines
1
to
4
| Significance: minor | ||
| Type: fix | ||
|
|
||
| Part of a larger change - renaming deposit to payout; this PR fixes instant payout modal + button |
There was a problem hiding this comment.
Suggested change
| Significance: minor | |
| Type: fix | |
| Part of a larger change - renaming deposit to payout; this PR fixes instant payout modal + button | |
| Significance: patch | |
| Type: dev | |
| Comment: Part of a larger change - renaming deposit to payout; this PR fixes instant payout modal + button | |
There was a problem hiding this comment.
Changed here, thank you! - 80cae5a
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Not sure if only dev or it can be any value here so that changelog is 'ignored'.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
I think the type can be update .. It should be patch and have a Comment, to be ignored from the main changelog .
The PR also delves into merchant-facing UI and hence logically should be update instead of dev.
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged based on my reply here
shendy-a8c
commented
Nov 8, 2024
Comment on lines
1
to
4
| Significance: minor | ||
| Type: update | ||
|
|
||
| Change deposit to payout in deposits list page. |
There was a problem hiding this comment.
Suggested change
| Significance: minor | |
| Type: update | |
| Change deposit to payout in deposits list page. | |
| Significance: patch | |
| Type: dev | |
| Comment: Change deposit to payout in deposits list page. | |
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged for now based on my earlier reply.
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged for now ref.
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged for now - ref .
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged for now - ref.
shendy-a8c
commented
Nov 8, 2024
| @@ -0,0 +1,5 @@ | |||
| Significance: patch | |||
| Type: update | |||
There was a problem hiding this comment.
Suggested change
| Type: update | |
| Type: dev |
There was a problem hiding this comment.
Keeping unchanged for now - ref.
…9680) Co-authored-by: Jessy <[email protected]> Co-authored-by: Nagesh Pai <[email protected]> Co-authored-by: Shendy <[email protected]>
|
Changelog looks good. Tested well on JN site. I can't approve my own PR... |
|
Bypassing branch rule that requires approval. Merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9595.
Changes proposed in this Pull Request
Part of project to rename
deposittopayout- paJDYF-fwb-p2.This PR is to merge the feature branch feature/deposits-payouts-rename that consists of renames from 'deposit' to 'payout'.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge