Remove unnecessary WC table css overrides to fix WC Analytics styling and a11y issues #9603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -287 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
jessy-p
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9572
Changes proposed in this Pull Request
This PR removes unnecessary CSS overrides of the
.woocommerce-tableclass that are causing style bugs on WC Analytics. The removed CSS overrides and increased specificity of styles in this PR fix the issue while having no/minimal impact on the rendered UI for WooPayments tables.WooPayments should avoid using CSS overrides where possible, to remain consistent with WC UI, avoid style conflicts and reduce complexity/maintenance burden.
Before/After
Tip
Before is lighter text, After is bolder text
Chromium (Arc browser 1.65.0)
Transactions
Documents
Disputes
Deposits
WC Analytics – no longer overriding styles
Safari iOS 18.0.1
Tip
Before is lighter text, After is bolder text
Transactions
WC Analytics – no longer overriding styles
Testing instructions
font-weightnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge