Ensure Stripe is loaded correctly when checking payment method availability #9523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
asumaran
approved these changes
Oct 7, 2024
reykjalin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9518.
Changes proposed in this Pull Request
This changes how the Stripe is loaded when we're checking whether the ECE payment method is available. ApplePay was returning as unavailable as Stripe was not being loaded with the merchant's account key, passing
truetoggles that.Testing instructions
Setup
Confirm issue: ApplePay is not displayed on checkout Blocks
You may try to test this with your local environment, but this may depend on whether you have verified your public domain on Stripe. If you can't confirm the issue locally, spin up a JN site and checks whether ApplePay is displayed in the checkout Blocks.
Test: Ensure ApplePay loads correctly on checkout Blocks
If you were able to test this locally you can just switch to this branch and build the assets:
npm run build:clientto check the fix. Otherwise, you'll need to build a package (npm run build:release) and upload in the JN site you created.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge