Fix settings rendering on the Advanced Fraud Protection page #9521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion settings page This mechanism was a hacky way of promoting a re-render in the page, and making the data immutable should make it unnecessary.
…e of truth Additionally, remove the code that could potentially make the page less reliable by directly changing the object without considering immutability concerns.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -89 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
ismaeldcom
approved these changes
Oct 18, 2024
Comment on lines
+43
to
+44
| const minItems = parseInt( settingUI?.min_items + '', 10 ); | ||
| const maxItems = parseInt( settingUI?.max_items + '', 10 ); |
There was a problem hiding this comment.
Not related to the PR, just out of curiosity, wouldn't be better to use Number here? It will remove the need to cast to string and use a radix.
There was a problem hiding this comment.
Yes, I think it would be better to use Number here instead of the multiple parseInt, but I'd be more comfortable having it in a different PR. I can open an enhancement issue to address that. It could even be something that we do on cooldown weeks. What do you think?
There was a problem hiding this comment.
Yep, definitely something to explore on a cooldown or similar 🙂
eduardoumpierre
deleted the
fix/9520-advanced-fraud-protection-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9520
Fixes #8747
Changes proposed in this Pull Request
This PR aims to fix the Advanced Fraud Protection page that wasn't rendering the settings as expected, which also impacted the confirmation modal before leaving the page.
The approach used was to remove any code that was changing the
protectionSettingsUIobject directly and the globaluseEffects, to have specifichandleChangefunctions for each form field. This makes the code simpler and adds immutability to the protection settings data.Testing instructions
Before checking out to this branch:
developand also update itgit pullnpm run startTest this branch
npm run startnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge