Using Floating Labels with Stripe Appearance API #9498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpressutto5
force-pushed
the
add/stripe-floating-labels
branch
from
9d30615 to
d4ef0a8
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +3.62 kB (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
gpressutto5
requested review from
a team and
FangedParakeet
and removed request for
a team
FangedParakeet
requested changes
Sep 27, 2024
There was a problem hiding this comment.
This looks great, appears to be working decently, and is a big improvement from the current state of this payment element in blocks. 🙌
Just have a few comments and questions about things I'd like to confirm aren't causing errors before proceeding with merging this PR. 🙏
FangedParakeet
requested changes
Oct 1, 2024
FangedParakeet
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9476
Changes proposed in this Pull Request
This PR implements the Floating Labels style for Stripe Payment Element on Blocks Checkout.
It also fixes how we get the style of the input and the label for the Blocks Checkout as some features were broken before.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge