Settings - Display erroring bank notice on Settings > Payments > Deposits #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +290 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Jinksi
reviewed
Sep 26, 2024
client/settings/deposits/index.js
Outdated
Comment on lines
213
to
222
| const { account, overview } = useSelectedCurrencyOverview(); | ||
| const selectedCurrency = | ||
| overview?.currency || wcpaySettings.accountDefaultCurrency; | ||
|
|
||
| const hasErroredExternalAccount = | ||
| account?.default_external_accounts?.some( | ||
| ( externalAccount ) => | ||
| externalAccount.currency === selectedCurrency && | ||
| externalAccount.status === 'errored' | ||
| ) ?? false; |
There was a problem hiding this comment.
💭 I found that when I used a multi-deposit-currency store, this notice did not display, and there is no way to see to change which currency is selected on the settings page.
What do you think about making this display if any deposit currency's default deposit account is in an errored state?
Suggested change
| const { account, overview } = useSelectedCurrencyOverview(); | |
| const selectedCurrency = | |
| overview?.currency || wcpaySettings.accountDefaultCurrency; | |
| const hasErroredExternalAccount = | |
| account?.default_external_accounts?.some( | |
| ( externalAccount ) => | |
| externalAccount.currency === selectedCurrency && | |
| externalAccount.status === 'errored' | |
| ) ?? false; | |
| const { overviews } = useAllDepositsOverviews(); | |
| const hasErroredExternalAccount = | |
| overviews.account?.default_external_accounts?.some( | |
| ( externalAccount ) => externalAccount.status === 'errored' | |
| ) ?? false; |
There was a problem hiding this comment.
What do you think about making this display if any deposit currency's default deposit account is in an errored state?
Thanks for testing this with a multi-currency account! what you shared here makes sense!
There was a problem hiding this comment.
I've tested this with a multi-deposit-currency store with a single errored deposit destination.
I did a round of manual test this time with a similar account, and it seems to work as expected.
Jinksi
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Nice one @nagpai 🌟
I've tested this with a multi-deposit-currency store with a single errored deposit destination.
I've left a suggestion to show merchants this if any deposit currency's destination is errored, rather than just the "selected" currency.
Other than that, this is a great addition for merchants on the Payments settings screen.
nagpai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8331
Changes proposed in this Pull Request
The PR adds a notice to
Settings > Payments > Depositsto inform the merchant whenever their bank account has an error. Check screenshot:Testing instructions
stripe payouts create --stripe-account="acct_123" --amount="123" --currency="USD"
Settings > Payments > Deposits, you will see an error notice similar to the one in the screenshotNotes
Payments > Overview > Depositsvia Added notice to inform merchant that their bank account has an error #8321 , and Deposits list screen via Adds notice that deposits are paused to Deposits Listing screen #8347npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge