Default express checkout button label to "Only icon" #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -2 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
bborman22
and removed request for
a team
bborman22
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
I confirmed this worked as expected for me with an existing site set to use the Donate option and it kept my existing option. I also tested with a new site and confirmed after install it was set to Only icon and displayed correctly.
I confirmed all checks were passing as well!
Only issue I found that wasn't related to this PR as it was happening on develop as well is that Stripe ECE doesn't seem to be respecting the buy setting or at least the buy setting is displaying the same as the only icon setting for me. I confirmed we're passing it to Stripe correctly and will open an issue on this separately.
LGTM!
rafaelzaleski
deleted the
fix/9332-default-express-buttons-only-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9332
Changes proposed in this Pull Request
Set the default Express Checkout button label to “Icon only”. Existing settings remain unchanged, and this will only apply to stores that have not previously configured a default label.
Testing instructions
Test 1: Existing Store (Previously Configured for Express Checkout)
Test 2: New Store (No Prior Express Checkout Configuration)
Additional Notes:
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge