-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design updates for Embedded Components #9381
Conversation
…cs (not a real key) to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmallory42 I've modified logo and the cancel button for the continue KYC page as well! Tried to refactor it, but it's tricky, so a bit of code duplication.
@dmallory42 - i don't know if this is related but when I create a store using the JN link above - the connect page is showing the sandbox mode notification at the top of the page before I do anything. Is that expected? The Stripe flow is also showing test mode - so maybe it's the way you set the JN to work? Aside from that - when I try to run through the flow and complete the Stripe OTP step - I get a session expired message and can't proceed. When I click add information again the window pops for a second and then takes me right back here. |
@timmy5685 The behavior you’re observing is expected due to the presence of the Dev Tools plugin, which is enabled by default on all JN sites created from the GitHub link and forces sandbox/dev mode. If you disable the Dev Tools plugin, both the sandbox mode and the notification should disappear. |
ok - thanks for confirming @mordeth! So that is also what is causing the expired session issue? |
No, I don't think so - I'm looking into this one 🙂 do you remember if you left the page open for a while when you saw that error, by any chance? |
…erce-payments into dev/i4-design-updates
Just to confirm, we merged a PR last week that should address any session issues. Please let us know if you spot anything like that again. |
cc @timmy5685 |
@orcunomattic could you please take a look and review it design-wise? 🙏 |
@oaratovskyi, the MOX + Stripe Embedded Onboarding screens look great! My only comment (as I mentioned on Slack) is on a color update request for button, text link and inline text link elements used in the MOX flow, as well as the header top header we use for both MOX and Stripe Embedded Onboarding: The other color change request (if possible) I have is for the "Continue" CTA on the Stripe authentication pop-up: it was a blue button (in color) previously, if we can revert it back to that WITHOUT affecting the top header area (which we switched to <Woo Purple 50>), that would be great, I am not sure if those two are connected: |
@timmy5685 As I've implemented @orcunomattic suggestions - merging this one and preparing the final build for you to test 🚀 |
@orcunomattic for the CTA focus - I think it should be dark blueberry |
@timmy5685 @orcunomattic I wrangled a PR to address this #9481 |
Fixes #9360
Changes proposed in this Pull Request
Note: we should hold off on merging this until the
dev/include-connect-js
PR is merged, and then target development.This PR contains updates to the embedded onboarding flow to match the i4 designs: xO8YdpKfaVoP2d8NvweZ5I-fi-1095_43454
Testing instructions
Embedded KYC
checkbox, then save the change.Screenshots:
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge