-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple './client/multi-currency-setup' #9348
Merged
Merged
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
a22e41c
Move client/data/multi-currency/* to multi-currency/client/data/*
lovo-h 0675fbf
Connect new MCCY data store: wc/payments/mccy
lovo-h fd9059b
Ensure non-MCCY reference the correct MCCY data files
lovo-h a9fffde
Remove unused MCCY test code
lovo-h ffb71c8
WebPack config: Add 'multi-currency' dir and alias with 'mccy'
lovo-h ae3b87d
Added a data interface layer where functions are shared
lovo-h 489e423
Move ./client/multi-currency-setup to ./multi-currency/client/setup
lovo-h 8c0868e
Add interface layer: components, functions, & data
lovo-h 6041e39
Use the 'functions' interface to inject dependencies into MCCY
lovo-h 635f3cd
Use the 'components' interface to inject dependencies into MCCY
lovo-h 64a47cd
Use the 'data' interface to inject dependencies into MCCY
lovo-h b93903a
Update multi-currency-setup's stale references to MCCY data files
lovo-h 3586349
Export MultiCurrencySetupPage from MCCY to main codebase
lovo-h 69a556f
Add temporary dependency on MCCY + TODOs
lovo-h 62eefc4
Fix tests: useStoreSettings imported from client
lovo-h 1f01897
Update 'mccy' alias to 'multi-currency'
lovo-h 588ab57
Merge branch 'migrate/data-multi-currency' into migrate/setup-multi-c…
lovo-h 10de47f
Update 'mccy' alias reference to 'multi-currency'
lovo-h 0d01922
Merge branch 'multi-currency-v2' into migrate/setup-multi-currency
lovo-h 1424558
De-duplicate WizardTaskItem
lovo-h 3b3e995
Code cleanup: Place imports in correct section, fix typo
lovo-h 4996381
Ensure getMultiCurrencyState refers to top level state
lovo-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/** | ||
* Dependencies from WooPayments to MCCY. | ||
*/ | ||
// wcpay/additional-methods-setup/* | ||
export { default as CollapsibleBody } from 'wcpay/additional-methods-setup/wizard/collapsible-body'; | ||
export { default as Wizard } from 'wcpay/additional-methods-setup/wizard/wrapper'; | ||
export { default as WizardTask } from 'wcpay/additional-methods-setup/wizard/task'; | ||
export { default as WizardTaskItem } from 'wcpay/additional-methods-setup/wizard/task-item'; | ||
export { default as WizardTaskList } from 'wcpay/additional-methods-setup/wizard/task-list'; | ||
// wcpay/components/* | ||
export { default as Page } from 'wcpay/components/page'; | ||
export { default as Search } from 'wcpay/components/search'; | ||
export { LoadableBlock } from 'wcpay/components/loadable'; | ||
|
||
/** | ||
* Dependencies from MCCY to WooPayments. | ||
*/ | ||
// multi-currency/setup | ||
export { default as MultiCurrencySetupPage } from 'multi-currency/setup'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
/** | ||
* Importing 'tracks' from WooPayments and exporting. | ||
* Dependencies from WooPayments to MCCY. | ||
*/ | ||
export { recordEvent } from 'wcpay/tracks'; | ||
// wcpay/data | ||
export { useSettings, useMultiCurrency } from 'wcpay/data'; | ||
|
||
/** | ||
* Importing data from MCCY and exporting. | ||
* Dependencies from MCCY to WooPayments. | ||
*/ | ||
export { useCurrencies, useEnabledCurrencies } from 'multi-currency/data'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
/** | ||
* Dependencies from WooPayments to MCCY. | ||
*/ | ||
// wcpay/tracks | ||
export { recordEvent } from 'wcpay/tracks'; | ||
// wcpay/settings | ||
export { default as WCPaySettingsContext } from 'wcpay/settings/wcpay-settings-context'; | ||
// wcpay/additional-methods-setup/* | ||
export { default as WizardTaskContext } from 'wcpay/additional-methods-setup/wizard/task/context'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: It seems like we have a pretty similar
WizardTaskItem
frominterface/components
. I wonder if we should use only one? And adapt V1 to have avisibleDescription
prop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. De-duplicated in 1424558.