Fix onboarding flows edge cases around onboarding mode #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +59 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
vladolaru
changed the title
6 tasks
dmallory42
approved these changes
Aug 28, 2024
mordeth
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for working on the issue, Vlad!
I’ve tested all the scenarios mentioned and can no longer replicate the issue.
Just a small suggestion regarding the testing instructions for the first case: it might be better to use the actions built ZIP rather than a locally built one, since we never encountered the issue with ZIPs built locally.
…und-onboarding-mode
mordeth
deleted the
fix/onboarding-flows-edge-cases-around-onboarding-mode
branch
|
Thank you @mordeth! I've updated the instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9342
Changes proposed in this Pull Request
We've investigated some weird edge cases (p1724745169469109-slack-C03KTTK2YMA) and while we haven't been able to pinpoint a single source of trouble, we've come to a set of highly confident suspicions:
yesandnovalues rather than boolean (WP is wonky about saving booleans in options (https://core.trac.wordpress.org/ticket/40007)Testing instructions
Testing without Dev Tools on JurassicNinja
testlabel in the Stripe KYC).Testing with Dev Tools locally, in dev mode
Checkout the PR branch on your local environment
Build the assets by running
npm run build:clientMake sure the "Enable the WCPay dev mode" checkbox is checked on the WCPay Dev page.
Go to the Payments page and you should see a notice at the top saying "Sandbox mode is enabled, only test accounts will be created. If you want to process live transactions, please disable it."
Onboard a test-drive account from the Payments page, "I'm setting up a store for someone else" section.
Then use "Reset account" from the Account tools section on the Payments > Overview page
Onboard another test-drive account from the Payments page, "I'm setting up a store for someone else" section.
Go to Payments > Settings, click on "Set up payments" button, click on the "Continue setup" button in the modal, and you should be redirected to the MOX wizard.
Finish the MOX and you should be taken to the Stripe KYC for our WCPay Dev Express platform account
Finish the Stripe KYC and you should have a working account and see the sandbox notice at the top of the Payments > Overview page.
Click on the "set up a live WooPayments account" link in the notice. A modal should open. Click on "Continue setup" and you should be redirected to the MOX.
Close the MOX and you should be taken to the Connect page with a sandbox mode notice at the top:
Testing with Dev Tools locally, without dev mode
npm run build:clientPlease note that retrieving deposits and transactions will not work with test mode active because of the "double test mode"; that is expected, at least until we decide to make some changes to our platform to cover this case - but since it is only a testing scenario for devs, we are OK with it.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge