Add PRBs support for express_checkout_enabled settings while detecting duplicates
#8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
timur27
requested review from
a team and
mdmoore
and removed request for
a team
timur27
changed the title
express_checkout_enabled settings while detecting duplicates
mdmoore
approved these changes
May 1, 2024
There was a problem hiding this comment.
I wasn't getting the notice at first. After digging around in the settings, I found dismissedDupliateNotices contained apple_pay_google_pay from testing on the original duplicate notices PR. This dismissed notice was triggered from a different Stripe plugin. After clearing the dismissed notices, this works as described, so LGTM!
It does raise the question of whether we should have some type of identifier for each notice based on the plugin from which it was generated. I'm imagining a scenario where a notice is dismissed, then later another plugin is installed which duplicates a payment method but no notice is displayed due to earlier dismissal. Just a thought for future improvement to the duplication service and not related to this PR.
🚢
Fair point @mdmoore, I'll create an issue for this to gather more feedback and decisions 👍 |
timur27
deleted the
add/third-party-plugin-support-for-duplicates-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8741
Changes proposed in this Pull Request
This PR adds support for detecting PRBs enabled by plugins which use the
express_checkout_enabledsettings to manage the PRB enablement.So far, there's only one plugin we're aware of (see more details in the parent issue), but there might be more.
Testing instructions
Enable Stripe Gatewayunderpage=wc-settings&tab=checkout§ion=cpsw_stripeandActivate Express Checkoutunder?page=wc-settings&tab=checkout§ion=cpsw_express_checkout?page=wc-settings&tab=checkout§ion=cpsw_express_checkoutand the notice is gone againnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge