-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak "Proceed to checkout" event tracking #8635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarcosta99
added
type: technical debt
This issue/PR represents/solves the technical debt of the project.
component: telemetry
The issue is related to Tracks instrumentation
labels
Apr 12, 2024
cesarcosta99
changed the title
Update/proceed to checkout tracking
Tweak "Proceed to checkout" event tracking
Apr 12, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +69 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ricardo
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: telemetry
The issue is related to Tracks instrumentation
type: technical debt
This issue/PR represents/solves the technical debt of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
After #8570, we are adding a cookie to bypass the WooPay checkout flow. This PR updates the
wcpay_proceed_to_checkout_button_click
event recording to take that cookie into account.If the cookie is set, it means the direct checkout won't be offered, and therefore, the
woopay_direct_checkout
property should befalse
.Testing instructions
Pre-requisites
npm run wp option update _wcpay_feature_woopay_direct_checkout 1
.npm run build:client
.Regression test: Proceed to Checkout event is tracked as expected
admin-ajax.php
in the dev tools. The request payload should contain the eventwcpay_proceed_to_checkout_button_click
and the propertywoopay_direct_checkout
should be evaluated totrue
.Test: Proceed to Checkout event takes the skip_woopay cookie into account
admin-ajax.php
in the dev tools. The request payload should contain the eventwcpay_proceed_to_checkout_button_click
and the propertywoopay_direct_checkout
should be evaluated tofalse
.npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge