Reduce overview sandbox mode notice footprint #8631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +164 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
vladolaru
changed the title
anu-rock
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Good work here 👏 I've left one minor comment.
Review checklist
| Parameter | Result |
|---|---|
| Approach | ✅ All good |
| Implementation | 👍 Almost good (left a comment about component extraction) |
| Automated tests | ✅ All good |
| Naming | ✅ All good |
| Typing | ✅ All good |
| Code comments | ✅ All good |
| Changelog | ✅ All good |
| Testing instructions | ✅ All good |
| Demo (video or JN site) or screenshots | ✅ All good |
| Manual testing |
mordeth
approved these changes
Apr 12, 2024
dpaun1985
approved these changes
Apr 12, 2024
anu-rock
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8449
Changes proposed in this Pull Request
Update the sandbox mode notice on the Payments Overview page for a smaller footprint:
I've also added Tracks events for the learn more links.
Before:
After:
Testing instructions
npm run build:clientwcadmin_wcpay_overview_sandbox_mode_learn_more_clickedevent fired when clicking on the "Learn more" link in the tooltip.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge