Reporting: Fix spelling of Payments to Payment
#8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -10 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
6 tasks
shendy-a8c
reviewed
Apr 14, 2024
shendy-a8c
approved these changes
Apr 14, 2024
There was a problem hiding this comment.
Looks good.
- I checked that UI does not have any 'payments'.
- No build error.
- Tests are all green.
- Ran
find client -iname '*payments*'and found no files related to reporting with 'payments'.
I have minor comment about changelog. Approving for now.
Also, need to inform the others @Automattic/helix so we're all aligned with this commitment to use singular term of 'payment' instead of payments in the existing open and future PRs.
shendy-a8c
added
pr: ready to merge
pr: needs author reply
and removed
pr: needs review
labels
haszari
reviewed
Apr 14, 2024
nagpai
added
status: blocked
added 7 commits
April 15, 2024 13:25
This reverts commit 1d58603.
nagpai
removed
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8629
Changes proposed in this Pull Request
Change the spelling of
PaymentstoPayment( singular ), to align with industry lingo and grammar.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge