Only register cart block PMME when BNPL is enabled #8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
timur27
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +404 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
timur27
reviewed
Apr 12, 2024
timur27
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Works well, thank you Mike! 🚢
PS feel free to accept or decline #8626 (comment), depending on which version you prefer more 😄
Co-authored-by: Timur Karimov <[email protected]>
naman03malhotra
pushed a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Timur Karimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
On
develop, an error is displayed on the cart block when no BNPL payment methods are enabled. This is because the PMME component was being registered while scripts it depends on were not. This adds a check to ensure BNPL payment methods are enabled before registering the component.Related: p1712858862185459/1712858745.223069-slack-CGGCLBN58
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge