Fixes "Invalid recurring shipping method" errors when purchasing multiple subscriptions with Apple / Google Pay #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
This was referenced Apr 11, 2024
eduardoumpierre
requested review from
a team and
gpressutto5
and removed request for
a team
gpressutto5
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I could not reproduce the Invalid recurring shipping method. error in develop, but I got a generic error message on the Apple Pay modal, and it is fixed by this branch, so I believe they are the same.
I tried testing this along with a trial subscription, but the button is not displayed when there's a trial subscription in the cart.
Also, while testing I got this error. This is not related to this PR, but do you know if this is expected?
|
Thanks @gpressutto5 for the review and test.
That's interesting. I just installed a fresh JN site and was able to reproduce it so not sure why you weren't able to get the error 🤔 There might be more steps that I didn't include in the PR description which are necessary to reproduce the issue like, making sure you have at least 2 shipping options available (free and flat rate).
This is expected :) Since the release branch has already been created, I'll merge this into Thanks! |
mattallan
added a commit
that referenced
this pull request
Apr 14, 2024
…iple subscriptions with Apple / Google Pay (#8618)
naman03malhotra
pushed a commit
that referenced
this pull request
Apr 15, 2024
…iple subscriptions with Apple / Google Pay (#8618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8029
Relevant slack thread: p1712735606268559-slack-C7U3Y3VMY
Supersedes #8602
Changes proposed in this Pull Request
When attempting to purchase multiple subscriptions of varying periods with Apple/Google Pay, you will get an "Invalid recurring shipping method." error:
This issue is caused by our
get_shipping_options()function wiping the chosen shipping methods when it recalculates shipping packages and available shipping methods, and then when Woo Subscriptions validates the checkout data onprocess_checkout, it throws an error because the recurring shipping methods are no longer set.This PR fixes these issues by restoring any chosen shipping methods that were wiped which belong to a recurring cart.
Testing instructions
developwhen you click on the Pay button, you will be hit with a checkout error:npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge