Pre check save my info for certain countries #8608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -1.37 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
leonardola
force-pushed
the
add/pre-check-save-my-info
branch
from
a6a9915 to
c464df5
Compare
alefesouza
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Code looks good and works as expected, I wonder if we shouldn't:
- Start the component without the error state to not surprise the user with the error message.
- Autocomplete the field when the user address is saved on the session (after a successful checkout) so the user does not need to fill out the phone number again, it's autocompleted if we uncheck and check the checkbox with the address phone number filled out.
- Maybe also auto update the WooPay phone field when the address phone field is changed, this way the user does not need to fill the phone number two times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR adds a pre check to the Save my info checkbox for certain countries.
Testing instructions
pre_check_save_my_infois set totruein the contentssave my info checkboxis pre checkednpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge