Add way to prepopulate MCC on MOX #8463

dmallory42 · 2024-03-26T08:28:17Z

Changes proposed in this Pull Request

Use the selected Woo Core vertical to prepopulate the selection on the MOX form (based on mapping from the platform - see https://github.com/Automattic/woocommerce-payments-server/issues/4854)

Testing instructions

Test 1

Spin up a new JN site from this branch.
During the WooCommerce Core onboarding, select a vertical (e.g. Clothing and Accessories)
Start the WooPayments onboarding.
When you are prompted to select the vertical/MCC, it should be prepoulated based on the value you selected in the Core onboarding, using the following mapping:

[
	'clothing_and_accessories'  => 'retail__clothing_and_apparel',
	'health_and_beauty'         => 'retail__beauty_products',
	'food_and_drink'            => 'food_and_drink__other_food_and_dining',
	'home_furniture_and_garden' => 'retail__home_furnishings_and_furniture',
	'education_and_learning'    => 'education__other_educational_services',
	'electronics_and_computers' => 'digital_products__other_digital_goods',
];

Test 2

Spin up another new JN site.
This time, skip the WooCommerce Core onboarding, not choosing an industry.
The WooPayments MOX should not prepoulate the value, instead it should be the default Select an option

Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Post merge

Link to testing instructions from release testing doc following these instructions : Add link here / 'QA Testing Not Applicable'
Add or update critical flows and testing instructions for critical flows, if applicable.
Add what's changed (description, screenshot, demo videos etc.) to the release announcement post, if applicable.

botwoo · 2024-03-26T08:31:20Z

Test the build

Option 1. Jetpack Beta

Install and activate Jetpack Beta.
Use this build by searching for PR number 8463 or branch name 8446-woo-core-verticals in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

Latest commit: bdd1a35
Build time: 2024-03-27 08:59:12 UTC

Note: the build is updated when a new commit is pushed to this PR.

github-actions · 2024-03-26T08:36:47Z

Size Change: +67 B (0%)

Total Size: 1.2 MB

Filename	Size	Change
`release/woocommerce-payments/dist/index.js`	290 kB	+67 B (0%)

ℹ️ View Unchanged

Filename	Size
`release/woocommerce-payments/assets/css/admin.css`	1.06 kB
`release/woocommerce-payments/assets/css/admin.rtl.css`	1.06 kB
`release/woocommerce-payments/assets/css/success.css`	158 B
`release/woocommerce-payments/assets/css/success.rtl.css`	158 B
`release/woocommerce-payments/dist/blocks-checkout-rtl.css`	1.92 kB
`release/woocommerce-payments/dist/blocks-checkout.css`	1.91 kB
`release/woocommerce-payments/dist/blocks-checkout.js`	54.1 kB
`release/woocommerce-payments/dist/cart.js`	4.45 kB
`release/woocommerce-payments/dist/checkout-rtl.css`	405 B
`release/woocommerce-payments/dist/checkout.css`	406 B
`release/woocommerce-payments/dist/checkout.js`	37 kB
`release/woocommerce-payments/dist/index-rtl.css`	40.1 kB
`release/woocommerce-payments/dist/index.css`	40 kB
`release/woocommerce-payments/dist/multi-currency-analytics.js`	1.05 kB
`release/woocommerce-payments/dist/multi-currency-rtl.css`	3.28 kB
`release/woocommerce-payments/dist/multi-currency-switcher-block.js`	59.4 kB
`release/woocommerce-payments/dist/multi-currency.css`	3.29 kB
`release/woocommerce-payments/dist/multi-currency.js`	54.5 kB
`release/woocommerce-payments/dist/order-rtl.css`	733 B
`release/woocommerce-payments/dist/order.css`	735 B
`release/woocommerce-payments/dist/order.js`	41.7 kB
`release/woocommerce-payments/dist/payment-gateways-rtl.css`	1.21 kB
`release/woocommerce-payments/dist/payment-gateways.css`	1.21 kB
`release/woocommerce-payments/dist/payment-gateways.js`	38.5 kB
`release/woocommerce-payments/dist/payment-request-rtl.css`	155 B
`release/woocommerce-payments/dist/payment-request.css`	155 B
`release/woocommerce-payments/dist/payment-request.js`	12.4 kB
`release/woocommerce-payments/dist/product-details-rtl.css`	155 B
`release/woocommerce-payments/dist/product-details.css`	155 B
`release/woocommerce-payments/dist/product-details.js`	16.6 kB
`release/woocommerce-payments/dist/settings-rtl.css`	11 kB
`release/woocommerce-payments/dist/settings.css`	10.8 kB
`release/woocommerce-payments/dist/settings.js`	199 kB
`release/woocommerce-payments/dist/subscription-edit-page.js`	669 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css`	527 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.css`	527 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.js`	19.4 kB
`release/woocommerce-payments/dist/subscription-product-onboarding-toast.js`	710 B
`release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css`	120 B
`release/woocommerce-payments/dist/subscriptions-empty-state.css`	120 B
`release/woocommerce-payments/dist/subscriptions-empty-state.js`	18.5 kB
`release/woocommerce-payments/dist/tos-rtl.css`	235 B
`release/woocommerce-payments/dist/tos.css`	236 B
`release/woocommerce-payments/dist/tos.js`	21 kB
`release/woocommerce-payments/dist/woopay-direct-checkout.js`	4.58 kB
`release/woocommerce-payments/dist/woopay-express-button-rtl.css`	155 B
`release/woocommerce-payments/dist/woopay-express-button.css`	155 B
`release/woocommerce-payments/dist/woopay-express-button.js`	21.1 kB
`release/woocommerce-payments/dist/woopay-rtl.css`	4.44 kB
`release/woocommerce-payments/dist/woopay.css`	4.41 kB
`release/woocommerce-payments/dist/woopay.js`	71 kB
`release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css`	622 B
`release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js`	812 B
`release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js`	2.43 kB
`release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js`	1.01 kB
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js`	522 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js`	581 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js`	160 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css`	2.37 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js`	13.5 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css`	2.37 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css`	1.03 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css`	291 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css`	403 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css`	3.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css`	299 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css`	742 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css`	572 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css`	411 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js`	9.4 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js`	6.8 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js`	3.83 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js`	2.52 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js`	22.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js`	11.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js`	1.29 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js`	502 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js`	355 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js`	429 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js`	1.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js`	781 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js`	1.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js`	1.27 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css`	392 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js`	3.05 kB

_{compressed-size-action}

…mmerce-payments into 8446-woo-core-verticals

anu-rock

Nice and quick, thanks for following it up so soon! Pre-approving this PR with a couple of nitpicky comments.

Review checklist

Parameter	Result
Approach	✅ All good
Implementation	✅ All good
Automated tests	Not applicable
Naming	✅ All good
Typing	👍 Almost good (left a comment)
Code comments	Not applicable
Changelog	👍 Almost good (left a comment)
Testing instructions	✅ All good
Manual testing	✅ Works as expected

Scenarios tested

Scenario	Result	Screenshot
Selected "food and dining" in Core onboarding	✅ WooPayments MOX had "food and dining" preselected
Did not select an industry in Core onboarding	✅ WooPayments MOX had nothing preselected

changelog/8446-woo-core-verticals

client/onboarding/utils.ts

…mmerce-payments into 8446-woo-core-verticals

Add way to prepopulate MCC.

13d6186

Merge branch 'develop' into 8446-woo-core-verticals

c228a7b

dmallory42 added 4 commits March 26, 2024 08:36

Update changelog.

40a946b

Tidying up.

b23534f

Merge branch '8446-woo-core-verticals' of github.com:Automattic/wooco…

edba99f

…mmerce-payments into 8446-woo-core-verticals

Remove unneeded import.

8c8c75c

dmallory42 marked this pull request as ready for review March 26, 2024 09:33

dmallory42 requested a review from a team March 26, 2024 09:34

dmallory42 added the pr: needs review label Mar 26, 2024

anu-rock approved these changes Mar 26, 2024

View reviewed changes

changelog/8446-woo-core-verticals Outdated Show resolved Hide resolved

client/onboarding/utils.ts Show resolved Hide resolved

client/onboarding/utils.ts Show resolved Hide resolved

dmallory42 added 4 commits March 26, 2024 13:15

Update changelog.

1375e04

Merge branch 'develop' into 8446-woo-core-verticals

6cbadb9

Adding comment to make intent more explicit.

044f273

Merge branch '8446-woo-core-verticals' of github.com:Automattic/wooco…

bdd1a35

…mmerce-payments into 8446-woo-core-verticals

dmallory42 added this pull request to the merge queue Mar 27, 2024

Merged via the queue into develop with commit 5f0b653 Mar 27, 2024
22 checks passed

dmallory42 deleted the 8446-woo-core-verticals branch March 27, 2024 09:22

anu-rock added pr: ready to merge and removed pr: needs review labels Mar 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add way to prepopulate MCC on MOX #8463

Add way to prepopulate MCC on MOX #8463

dmallory42 commented Mar 26, 2024 •

edited by vladolaru

Loading

botwoo commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading

anu-rock left a comment

Add way to prepopulate MCC on MOX #8463

Add way to prepopulate MCC on MOX #8463

Conversation

dmallory42 commented Mar 26, 2024 • edited by vladolaru Loading

Changes proposed in this Pull Request

Testing instructions

botwoo commented Mar 26, 2024 • edited Loading

Test the build

Option 1. Jetpack Beta

Option 2. Jurassic Ninja - available for logged-in A12s

github-actions bot commented Mar 26, 2024 • edited Loading

anu-rock left a comment

Choose a reason for hiding this comment

Review checklist

Scenarios tested

dmallory42 commented Mar 26, 2024 •

edited by vladolaru

Loading

botwoo commented Mar 26, 2024 •

edited

Loading

github-actions bot commented Mar 26, 2024 •

edited

Loading