fix: error message on 402 status code #8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
frosso
requested review from
a team and
brettshumaker
and removed request for
a team
brettshumaker
approved these changes
Mar 22, 2024
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Brett Shumaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8079
Changes proposed in this Pull Request
Stripe will sometimes return a 402 error code when a payment fails.
402 is problematic on some hosting (well, the only one we're aware of is Atomic & JN). So let's just return
400when a402is returned by Stripe.There are also other error codes that have custom responses, but let's start with
402: p1707297315719429-slack-C7YPW6K40The argument for returning the
400is: if Stripe returns a500error, would our plugin need to return a500error?Our plugin worked fine, and the communication with Stripe worked fine as well.
Testing instructions
You'll need an atomic site or a JN site to test the symptoms:
4000000000000002npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge