Payments settings improvements #8428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +82 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
timur27
commented
Mar 22, 2024
There was a problem hiding this comment.
I think that this task is not part of the flow anymore. I will confirm it and remove it separately.
frosso
reviewed
Mar 25, 2024
There was a problem hiding this comment.
The changes are providing an excellent improvement, great idea!
One thing I'd like to note as an implementation alternative: I noticed the change in client/settings/save-settings-section/index.js that updates the data store within the component. In order to do so, you also needed to change the implementation of the useGetPaymentMethodStatuses and the implementation (and return value) of the saveSettings action.
But with this, you're relying on the client/settings/save-settings-section/index.js component's body to do the update, and the usePaymentMethodStatuses is now a hook that can technically also update the payment_method_statuses settings key (even tho this settings key doesn't have a related UI element).
By implementing this change on the saveSettings action, you can avoid modifying useGetPaymentMethodStatuses (and all the related test/component changes), and you can also avoid relying on the client/settings/save-settings-section/index.js component to do the update:
yield updateIsSavingSettings( true, null );
const response = yield apiFetch( {
path: `${ NAMESPACE }/settings`,
method: 'post',
data: settings,
} );
yield updateSettingsValues( {
payment_method_statuses: response.data.payment_method_statuses,
} );
yield dispatch( 'core/notices' ).createSuccessNotice(
__( 'Settings saved.', 'woocommerce-payments' )
);What do you think of this alternative?
timur27
force-pushed
the
settings/updates-improvements
branch
from
afb850b to
6336843
Compare
|
@frosso Love the suggestion, I applied it because it's definitely the better way of doing things! Thanks! |
frosso
approved these changes
Mar 26, 2024
frosso
approved these changes
Mar 26, 2024
|
Thank you @frosso ! |
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Timur Karimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8246
The ACs for #8246 are essentially listed in #8246 (comment).
Changes proposed in this Pull Request
This PR removes the spinner when checking the payment method on the Settings page (the spinner was there only to meet design expectations. Confirmed in this discussion.
This PR also updates payment method statuses if they were updated after clicking the
Save settingsbutton. This means that merchants don't necessarily need to refresh the page to see the update.Testing instructions
Payment methods checkbox has no spinner
idealin Settings$this->account_data['capability_requirements']['ideal_payments'][] = 'business_profile.support_email';, clear account cachePayment methods list updates after saving settings without the need to refresh the page
Rejectedwithout refreshing the pagenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge