Add BNPL to cart summary #8427
Merged
Add BNPL to cart summary #8427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +26.2 kB (+2%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
gpressutto5
requested changes
Mar 27, 2024
@gpressutto5 Looks like this is due decimals being set to 0. The updated value is coming from the store API and isn't prepared like the initial amount is via |
|
@gpressutto5 The updated amount is correct now. It was also an issue on the cart block when decimal precision was not 2. It's resolved now when you have time for another look. |
gpressutto5
approved these changes
Mar 28, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8144
Changes proposed in this Pull Request
This adds the Stripe BNPL Payment Method Messaging Element to the cart summary on cart pages. For for classic cart, the PMME is mounted to a div that's added to the page. For the cart block, the Stripe
<PaymentMethodMessagingElement />component is used. Using this element required updating thestripe/react-stripe-jspackage. I've used the latest version of the package, so one thing to consider is whether this update will cause any issues and if an earlier package should be used.This also integrates the Appearance API based on #8421.
Testing instructions
Testing the Appearance API
For classic themes, add some custom CSS to change fonts and background colors, such as:
Closing the Customizer will clear the transient.
For block based themes, change to a dark style. In Twenty Twenty-Four, easy to go Appearance > Editor > Styles > Onyx. Saving this style doesn't clear the transient, unfortunately. It will have to be cleared manually.
npm run wp transient delete wcpay_upe_bnpl_cart_block_appearanceandnpm run wp transient delete wcpay_upe_bnpl_cart_block_appearance_themeshould do the trick.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge