skip main gateway from updates on migration script #8419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
gpressutto5
reviewed
Mar 19, 2024
docker-compose-override.yml
Outdated
There was a problem hiding this comment.
I think you committed this file by mistake?
There was a problem hiding this comment.
Yes sorry, fixed in 9430bc7
gpressutto5
approved these changes
Mar 19, 2024
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Timur Karimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Currently, the migration script for gateway settings will be applied to the main card gateway as well in this place. First, it's not needed because
cardgateway settings weren't changed and thus don't need a migration. Secondly, this has a side effect on the gateway enablement email notification which doesn't enter this branch because the card gateway was enabled on the migration and thus isn't new anymore.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge