Update phpcs and related sniffs #8415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reykjalin
requested review from
a team and
ricardo
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +6 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
These are the rules that have issues reported after updating the sniffs:
And some leftovers fixed in b6301d6. So those are all rules we have to make a decision on. I found these by writing the phpcs report to json and using ./vendor/bin/phpcs --standard=phpcs.xml.dist (git ls-files | grep '.php$') --report=json > issues.json
vi issues.json # And remove the empty lines and PHPCS report
cat issues.json | jq '.. |."source"? | select(. != null )' | sort | uniq |
|
I've been working through the list but it's taking a bit of time. I've settled on trying to use
./vendor/bin/phpcs --standard=phpcs.xml.dist $(git ls-files | grep '.php$') --sniffs='PSR12.Functions.ReturnTypeDeclaration'
./vendor/bin/phpcbf --standard=phpcs.xml.dist $(git ls-files | grep '.php$') --sniffs='PSR12.Functions.ReturnTypeDeclaration'
@bborman22 this is taking longer than it's expected, but I think it's important that we get this done because:
The longer this drags the harder it will be to merge due to the amount of files this touches. The things we can't auto-fix via Note that all of these issues appeared after I updated the sniffs and PHPCS, they were not present before. @ricardo I've already seen some things that will probably need to discuss:
Probably some others similar to this, or maybe ones we have to fix, but this is as far as I've gotten today. |
This was referenced Mar 21, 2024
asumaran
approved these changes
Mar 22, 2024
|
Awesome! I just merged from I'll wait for tests to pass and add a changelog entry before I merge. |
6 tasks
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Note
There are currently way more issues reported after the update. Not sure which ones are false positives, which can be silenced, and which ones we should fix.
npm run lint:phpindevelopand make a note of the issues reported (there should be none)./opt/homebrew/opt/[email protected]/bin/php ./vendor/bin/phpcs --standard=phpcs.xml.dist $(git ls-files | grep .php$)composer install.npm run lint:phpand make sure you see the same issues reported as indevelop.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge