Fix UPE fields erroneously showing black background in some themes. #8404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng color. - When this function was passed `rgba(0,0,0,0)` it returned black when the color was really transparent. It will now return white in this scenario. - Also updates regex to account for extra spaces in the rgba value
brettshumaker
requested review from
a team and
frosso
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +84 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
frosso
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8381
Changes proposed in this Pull Request
On some themes, the credit card fields from UPE were displaying a black background when they shouldn't have. The UPE appearance is generated on the checkout page and we're trying to make an educated guess as to what the styles of the input fields should be. The reported issue occurred when
rgba(0,0,0,0)(transparent) was being detected and we turned that intorgb(0,0,0)(black). We now returnrgb(255,255,255)in this scenario.I've also made the regex detecting
rgbaa bit more robust.Testing instructions
[woocommerce_checkout]shortcode and publish the page.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge