Initialises BNPL payment messaging element with Stripe account ID #8377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +7.91 kB (+1%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
brettshumaker
approved these changes
Mar 13, 2024
FangedParakeet
deleted the
fix/adds-correct-options-to-bnpl-messaging-element
branch
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Adds missing parameters to Stripe initialisation when mounting BNPL payment messaging element
This PR uses the
WCPayAPIobject to instantiate theStripeinstance used to create and mount the payment messaging element. We add the missingaccountIdparameter, as well as thelocaleparameter, to the initialisation, as well as ensuring we have a consistent implementation to summon Stripe that includes any other auxiliary parameters used at checkout, such as including optionalbetas, for example.This should resolve the pertinent misplaced parameter problem, while hopefully using a more robust, shared utility.
Testing instructions
/includes/payment-methods/...to confirm amount, currency, and country restrictions).npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge