Ensure every gateway has individual settings object #8361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
timur27
requested review from
a team and
FangedParakeet
and removed request for
a team
timur27
force-pushed
the
fix/gateway-individual-settings
branch
from
8820114 to
d940780
Compare
…into fix/gateway-individual-settings
FangedParakeet
approved these changes
Mar 8, 2024
6 tasks
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Timur Karimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8349
Changes proposed in this Pull Request
A few weeks ago, we started to register all known payment methods in WooCommerce during plugin initialization. This was done for our system to work correctly as WooCommerce expects all gateways (even enabled ones) to be registered.
After that change, multiple third-party actors (WooCommerce and WooCommerce Blocks) started to behave differently, by introducing two new symptoms: spamming with emails after WooPayments plugin gets enabled, and spamming with incompatible payment methods in Blocks editor.
All this happens because we are now treating gateways separately, while still keeping settings for them in the centralized settings option.
This PR ensures that every gateway has its own settings object, which eventually resolves all the problems mentioned in #8349.
While this solution is the fix, the design of settings options still requires improvements, by e.g. ensuring the
enabledproperty is in line with gateway's status and by e.g. removing the array with enabled UPE methods since we now have separate settings withenabledflag. Those are improvements unrelated to #8349 and I'll make sure we act there as well, but separately.Testing instructions
Create a new JN site. As WooPayments plugin, use this version.
Pagesin the admin panel and make sure the warning about incompatible gateways (screenshot here) is not presentWooCommerce -> Settings -> Payments), refresh the page and confirm the disablement status is still in placenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge