Add payments activity widget emoji survey #8309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmallory42
reviewed
Mar 4, 2024
mordeth
requested changes
Mar 4, 2024
oaratovskyi
reviewed
Mar 4, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.76 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
Nitpick - We should change the title of this PR to more accurately reflect the component's name. Payments Overview Widget is the parent component of which this PR's component is a part of. |
mordeth
requested changes
Mar 6, 2024
client/overview/survey/emoticons.js
Outdated
| ( rating === currentRating ? ' selected' : '' ); | ||
|
|
||
| const getIcon = function () { | ||
| if ( rating === '1' ) { |
There was a problem hiding this comment.
Considering the significant markup duplication in that function, I propose passing the unicode emoji text as a prop and retain only one instance of <span role="img" aria-label="emoticon">.
There was a problem hiding this comment.
In addition, another thing we could do to here is have an object (similar to what we do in strings.tsx files) where we map emoji IDs to the appropriate unicode text and use this function to just check the array to make sure rating is valid and render the span with the approriate unicode.
There was a problem hiding this comment.
changed in 2f32d7c thx!
dmallory42
reviewed
Mar 6, 2024
dmallory42
reviewed
Mar 6, 2024
oaratovskyi
reviewed
Mar 7, 2024
oaratovskyi
reviewed
Mar 11, 2024
oaratovskyi
reviewed
Mar 11, 2024
oaratovskyi
reviewed
Mar 11, 2024
oaratovskyi
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Thanks for your work on this PR! I have left a few nitpicks and one minor comment (about translation)
Also I asked a question in slack related to the survey results p1710168340907879/1709737434.351679-slack-C03KTTK2YMA
could you please take a final look? I'll be happy to approve after that! 🚢
|
handover comments pepjwh-Ok-p2#comment-926 |
Jinksi
changed the title
Jinksi
changed the base branch from
develop
to
add/8389-create-payment-activity-wrapper
added 15 commits
March 28, 2024 12:03
Jinksi
force-pushed
the
add/8197-overview-survey
branch
from
0f03609 to
1791f0d
Compare
|
Ah FFS I made a mess of this rebase |
Base automatically changed from
add/8389-create-payment-activity-wrapper
to
develop
March 28, 2024 02:49
Jinksi
force-pushed
the
add/8197-overview-survey
branch
from
7406ab0 to
1791f0d
Compare
13 tasks
|
Moved to #8506 to clean up the mess I made of the commit history. Commits have been cherry-picked to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Emoji-based survey component to capture the user sentiment for the new Payments Overview Widget.
Todo
Testing instructions
wp option update _wcpay_feature_payment_overview_widget 1in CLIpublic-api.wordpress.comanddev-mc.a8c.comto your sandbox's IP address if you didn't alreadyPayments -> OverviewMJ5lCh.mp4
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge