Prevent sending shopper emails when disputes are closed #8308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucealdridge
commented
Mar 4, 2024
Comment on lines
+350
to
+351
| add_filter( 'woocommerce_email_enabled_customer_completed_order', '__return_false' ); | ||
| add_filter( 'woocommerce_email_enabled_customer_refunded_order', '__return_false' ); |
There was a problem hiding this comment.
I considered only adding the specific filters inside the if, but it seemed more readable to me to add and remove both at the same time.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
Manual testWithout patch
With Patch
Code feedback
|
nagpai
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7928
Changes proposed in this Pull Request
When a dispute is created, WooPayments will mark the order as
on-hold. When the dispute is closed, the order is marked ascompletedorrefundeddepending on the disputestatus.The changing of the status to either
refundedorcompletedtriggers WooCommerce to send an email.refundedemailcompletedemailIn both cases, these emails should not be sent. In the case of
completedthe shopper will be confused as to why they are receiving the email.For
refundedthere are some benefits to still sending the email as it will let the shopper know that they are being refunded. However, as this refund is handled by Stripe and the shoppers' bank there may be a delay in receiving it. It is best to allow the shoppers' bank to communicate the dispute outcome.This PR adds a filter to block these emails from being sent as the order status is being changed. This will fix the immediate issue of emails being sent.
Long-term, disputes should have custom statuses. See #8306
Testing instructions
Setup
4000000000002685(triggersnot receiveddispute).Order complete emails
winning_evidence.Your [STORE] order is now completeOrder refunded emails
losing_evidence.Your [STORE] order has been refundednpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge