-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accidental pushes to develop
and trunk
#8287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
changed the title
Avoid accidental push to develop
Avoid accidental pushes to Feb 28, 2024
develop
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
timur27
commented
Feb 28, 2024
timur27
changed the title
Avoid accidental pushes to
Avoid accidental pushes to Feb 29, 2024
develop
develop
and trunk
timur27
requested review from
a team and
gpressutto5
and removed request for
a team
February 29, 2024 13:52
gpressutto5
force-pushed
the
avoid-accidental-push-to-develop
branch
from
February 29, 2024 16:35
edd6482
to
f83ccb6
Compare
gpressutto5
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 tasks
Jinksi
pushed a commit
that referenced
this pull request
Mar 28, 2024
Co-authored-by: Timur Karimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Adds additional confirmation step when pushing to protected branches to mitigate accidental pushes.
More in paJDYF-cFD-p2
Testing instructions
PROTECTED_BRANCH
variable so that it containsavoid-accidental-push-to-develop
y
is providednpm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge