Update CSV export language codes to align with the languages supported by the server #8190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
allie500
reviewed
Feb 13, 2024
|
Thank you for the quick review! The behavior you're experiencing is expected because the Spanish translation files are not present in your environment, they are only available in production. I've made the necessary updates to the steps. |
allie500
approved these changes
Feb 13, 2024
allie500
pushed a commit
that referenced
this pull request
Feb 14, 2024
…d by the server (#8190) Co-authored-by: Dan Paun <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
At present, the default WordPress locale codes do not align with the supported languages on the server. This PR modifies the WordPress locale codes to match the supported languages.
Additionally, it hides the CSV export modal if the language is not supported.
Testing instructions
Case 1
Settings->General.Spanish.Payments->Settings.Case 2
Settings->General.Bulgarian.Payments->Settings.Case 3
Settings->General.Spanish.Payments->Transactions.Remember the languagesettings checkbox.Site language->Spanishand click download.localeparam in the request ises.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge