Remove Woo plugin header #8050
Merged
Remove Woo plugin header #8050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
vbelolapotkov
force-pushed
the
update/translations-loading
branch
from
4c8a0ab to
355241b
Compare
|
Note for the first reviewer: I think the code is not in the right place, but should work. Please focus on testing and validating solution at this point. I'd appreciate the following recommendations:
|
…ill lots of pointless work to cover it with tests
|
@RadoslavGeorgiev I think it's ready for a final round of review and testing with fresh eyes before merging. FYI, it's not urgent, so can easily wait a bit longer than usual PRs. |
|
Notes on failing tests. None of the failures seem to be related to PR changes. More notes in slack: p1706873714162189-slack-CGGCLBN58 |
RadoslavGeorgiev
approved these changes
Feb 5, 2024
|
Merging since failing checks are not related to this PR. Fix for E2E tests is in #8123. |
|
Testing instructions for 7.2.0 are updated: https://github.com/Automattic/woocommerce-payments/wiki/Release-testing-instructions-for-WC-Payments-7.2.0 No update for critical flows needed. Nothing is changed in UI, plugin behavior, so not updating release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some internal problems caused by existence of Woo header in the plugin file.
However, removing Woo header will break mechanism used for loading translations from translate.wordpress.com.
This PR removes Woo header and fixes the problem with loading translations.
More context in p1705063122937369-slack-CGGCLBN58
Changes proposed in this Pull Request
Test coverage exception
Most of the code interacts directly with WordPress plugin update process, so there is very little value in covering it with automated tests, because it'll require lots of mocking and code without really testing the behavior.
This decision was discussed with @RadoslavGeorgiev in a call (p1706252630150489-slack-CGGCLBN58).
Testing instructions
If using dev tools plugin, disable proxy for wordpress.com. Server is not needed in these tests, but downloading files from translate.wordpress.com is.
Open debug.log file
wp-content/debug.logto monitor errors in the process.Open plugins translation folder in your file manager. The path depends on your WP installation (local or within docker), bur the relative path is
wp-content/languages/pluginsRemove all the existing translations files (it's pretty safe, new translations will be loaded).
Go to WP admin dashboard > Settings > General, and change language to one of the languages supported by WooPayments: https://woo.com/document/woopayments/customization-and-translation/translations/
Go to WP updates page:
/wp-admin/update-core.php, at the bottom of the page a button to update translations should appear, click it to load new packages.Once update process is completed check that translations for WooPayments appeared in translation folder mentioned above.
Check that plugin pages have translations.
Compare the translation files with files from wordpress.com. For this:
7_0_0.*fr_fr.zip. Note, do not use files from test builds (they havetestin file name).https://translate.files.wordpress.com/<file name starting from date>. Example:https://translate.files.wordpress.com/2024/01/woocommerce-payments-7_0_0-1704390844-es_es.zip.Try the same steps by selecting new language in Settings > General.
Try removing some .po files from WP translations folder, and go back to WP updates page:
/wp-admin/update-core.php, new translations should be offered again.Try breaking the flow either by enabling local server proxy, or introducing some fake exceptions/errors. There should be no errors logged in debug.log from WooPayments, but error message should be logged in WooPayments log file in Woo > Sytem > Logs.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge