Cleanup the removed scripts rollout #7911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
changed the title
timur27
force-pushed
the
cleanup/redundant-script-enqueueing
branch
from
2502c35 to
a23d88e
Compare
timur27
force-pushed
the
cleanup/redundant-script-enqueueing
branch
from
204ad93 to
79a0835
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
timur27
requested review from
a team and
frosso
and removed request for
a team
timur27
changed the title
frosso
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7909
Changes proposed in this Pull Request
After one of the recent cleanups, we are using the old UPE split class to enqueue scripts. It extends
WC_Payments_Blocks_Payment_Methodwhich enqueues everything needed for the checkout. Right after, we're additionally trying to roll out split UPE scipt whichblocks-checkoutThis led to
404and because this script was not needed, there was no regression in terms of the functionality. This situation led me to the conclusion that we simply don't needWC_Payments_UPE_Split_Blocks_Payment_Methodand we should useWC_Payments_Blocks_Payment_Methodwith its implementation ofget_payment_method_script_handlesthat covers everything (and was also executed previously)Testing instructions
develop, open Blocks checkout, confirm that you see404for upe split script in the network tab, while alsoblocks-checkout.jsis rolled out (screenshot)cleanup/redundant-script-enqueueing, confirm no upe split is enqueued andblocks-checkout.jsis still rolled out (screenshot)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge