Add subscription variation support to WooPay button #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmoore
requested review from
a team and
gpressutto5
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
gpressutto5
reviewed
Dec 15, 2023
I don't think this is expected. I'm seeing the buttons on variable subscription products on
This is where the weirdness comes in. It will work fine with a normal variable subscription product. To reproduce, you'll need to grab the ID of the subscription variation and hardcode it here. This will simulate purchasing a Find the variation ID here:
The product is initially added to the cart and the GPay modal might show the correct total, but then will update to 0 after. Reproducing the error will look like this:
Let me know if you're still unable to reproduce it and I'll try my best to help. It's a strange thing. |
gpressutto5
approved these changes
Dec 18, 2023
Ah, nice catch! Sorry I didn't notice that in your screenshot. There's one JS test failing, but that's due to a different PR. I'll proceed with merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7588
Changes proposed in this Pull Request
This adds support for the
subscription_variationproduct type to the WooPay button, similar to what's done for payment request buttons.Testing instructions
This covers an edge case and is a bit awkward to test. Variable Subscription products have the type,
variable-subscriptionand the actual variations have the type,subscription_variation. When navigating to a variable subscription product and purchasing a variation, the the express checkout buttons will seevariable-subscriptionas the product type. There is some case in which a subscription variation can be purchased while not attached to it's parent product, at which point the product type will besubscription_variation. Myself and others haven't been able to find a way to purchase a subscription variation via normal core flows.Instructions
$product_idto the ID of the variation here. This will result in thatsubscription_variationbeing added to the cart any time the WooPay or payment request button is used.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge