Transactions List - indicate when a transaction is expected to be included in a future deposit #7878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Jinksi
changed the title
|
Size Change: +97 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Jinksi
changed the title
Why is this? I'm not too familiar with loan feature. When merchant gets a loan, isn't the money paid out in the form of a deposit? |
shendy-a8c
approved these changes
Dec 12, 2023
|
In case merchants want more details, should we include a |
Great idea, I'll add this! |
At the moment, we show loan financing transactions as individual transactions separate from (rather than within) a deposit. @souravdebnath1986 has mentioned that we want to rectify this in the future, at which point financing types will have a deposit date and will show up within the deposit details transaction list. Example: below is the same deposit, including a financing repayment. Stripe shows the financing repayment within the transactions list. 
WooPayments Deposit details transaction list doesn’t include this and therefore the totals don’t add up. In 6.8.0, it is especially confusing, since these show an estimated deposit that never arrives. I'll check to see if there is an open issue for this and create one if not. |
Jinksi
force-pushed
the
add/transaction-list-future-deposit
branch
from
7a1d9ba to
c7fa489
Compare
|
Rebased to |
|
I've updated this PR by adding a Learn More link that directs to I've also added the text "Future deposit" to the row's value, alongside the tooltip icon. |
|
Retested and looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7876
Changes proposed in this Pull Request
In the Transactions List, for transactions that are not included in a pending/paid deposit, render "Future deposit" and an info icon in the "Deposit date" column.
Clicking this icon will present a tooltip with the message:
This will render for all transaction types except
financing_*. See list of transaction types.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge