Fix incorrect amounts caused by zero-decimal currencies on JS CSV export #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +2 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7834
Changes proposed in this Pull Request
This PR addresses the issue of incorrect amounts in Transactions, Deposits, and Disputes on CSV exports when there are fewer than 25 products. It specifically resolves discrepancies with zero-decimal currencies like the Japanese Yen (JPY), ensuring that the amounts are no longer displayed 100 times lower than intended.
Amounts before the changes
Amounts after the changes
Demo
https://github.com/Automattic/woocommerce-payments/assets/8667118/7fef0481-d4a6-4e69-9e5c-793bbe9e252b
Testing instructions
Prerequisites
Case 1
Case 2
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge