Pass currency and do not pass transaction_ids parameter to create instant deposit #7828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -25 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
shendy-a8c
commented
Dec 4, 2023
| Significance: minor | ||
| Type: update | ||
|
|
||
| Pass currency parameter and not transaction_ids parameter when creating instant deposit. |
There was a problem hiding this comment.
Should we add a changelog entry for this kind of change, one that is not user facing and a change that is only 'in the background'?
I assume yes but like a confirmation.
Jinksi
reviewed
Dec 5, 2023
| @@ -235,18 +235,18 @@ export const useDepositsSummary = ( { | |||
| }; | |||
|
|
|||
| export const useInstantDeposit = ( | |||
| transactionIds: string[] | |||
| currency: string | |||
| ): { inProgress: boolean; submit: () => void; deposit: unknown } => { | |||
There was a problem hiding this comment.
Thought (out of scope of this PR): we should use an interface from deposits.d.ts here.
However, low priority, since this value from this hook is actually not currently used in our codebase (we only use inProgress and submit).
There was a problem hiding this comment.
I was wondering about that actually, whether it's necessary to return deposit since it's not used anywhere.
Do you think I should delete deposit, inProgress from the return value, and getInstantDeposit?
I tried to do that and there are a lot of things can be deleted. However, I thought they are necessary to keep the state of the button so we can use it to remove the button after an instant deposit is created but actually, even after preserving them (deposit and inProgress), the button still does not disappear after an instant deposit is created. I created #7841 for that.
Jinksi
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Looks good @shendy-a8c!
I've tested this as per instructions with the server branch from PR 4061.
I suggest we add I've added the blocked label to indicate that this PR should not be merged until server PR 4061 is merged!
Jinksi
added
status: blocked
Created #7841. |
14 tasks
Jinksi
reviewed
Dec 7, 2023
| @@ -54,7 +54,6 @@ export interface InstantBalance { | |||
| fee: number; | |||
| net: number; | |||
| fee_percentage: number; | |||
| transaction_ids: Array< string >; | |||
|
Removing |
brucealdridge
removed
the
status: blocked
|
Failed e2e tests are not related to this PR's changes. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7711
Changes proposed in this Pull Request
When creating instant deposit:
currencyparameter.transaction_idsparameter.Testing instructions
/wp-json/wc/v3/payments/deposits./wp-json/wc/v3/payments/depositshascurrencyparameter and nottransaction_ids.ps: after a successful instant deposit, the 'Deposit available funds' button state does not get updated, ie if user has exceed daily limit, the button should be hidden, etc. I'll create a separate issue for this.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge