Update international IP address rule card behavior when the rule is being affected by another configuration #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +10 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Update allow-countries-notice snapshots
jessepearson
requested changes
Dec 5, 2023
There was a problem hiding this comment.
I had a question about a variable declaration that was done. I tested and it works either way, so it's not a necessary change if it's better for clarity.
There's the issue of the country names with extended ascii characters not displaying correctly. Do you think you can fix that in this PR without much hassle, or do you think it needs another issue and separate PR?
client/settings/fraud-protection/advanced-settings/cards/international-ip-address.tsx
Outdated
Show resolved
Hide resolved
Thanks for catching this! I looked in to this and it needs to be fixed in Woo core. In the WooPayments code we are getting the countries from If you run That is hardcoded in the core countries file: I can open an issue in core to track this. |
Actually, it does look like something on our end as core does properly decode the entities on their end. I'll open a separate issue for it in this repo. |
…d-by-other-config
jessepearson
approved these changes
Dec 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…d-by-other-config
…d-by-other-config
allie500
deleted the
update/6320-rule-card-behavior-if-affected-by-other-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6320
Changes proposed in this Pull Request
This PR modifies the behavior and display of the international IP address rule card if the rule is being affected by the WooCommerce core selling locations general option. Previously, if the WooCommerce core selling locations option was set to 'sell to all countries' we'd show a notice at the bottom of the card but still display the toggle to enable the rule as shown in the screenshot below:
The changes in this PR have updated the rule card display to not show the rule toggle and instead show the notice in the toggle's place with updated text indicating that filter is disabled because the WooCommerce core selling locations option is set to 'sell to all countries'. See the screenshot below:
The behavior and display of the rule card has not been changed if the the WooCommerce core selling locations option is set to the 'specific countries' or 'all countries except' options.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge