Fix PO Notice not appearing when adding APMs #7552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to show the tooltip with a link to the gradual signup docs.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +41 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
ismaeldcom
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7548
Changes proposed in this Pull Request
Testing instructions
npm run listenon the server).Payments > Settingsand verify that you can see the new warning icon and tooltip on all payment methods except card, and that clicking theLearn morelink takes you to the Gradual Signup docs relating to adding payment methods (note: the actual content of the doc is slightly out of date and will be updated soon).Payments > Settings- the warning icons and tooltips should still display, but theLearn morelink should go to the APMs documentation (not gradual signup docs).completestate and you should now be able to add APMs as normal.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge