Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant OTP events #7542

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Remove redundant OTP events #7542

merged 2 commits into from
Oct 26, 2023

Conversation

malithsen
Copy link
Member

The Tracks events in the WooPay OTP flow recorded from the merchant site are no longer needed. We have equivalent events recorded from WooPay so these events can now be removed.

Changes proposed in this Pull Request

Tracks events removed:

woocommerceanalytics_woopay_otp_prompt_start
woocommerceanalytics_woopay_otp_prompt_complete
woocommerceanalytics_woopay_otp_prompt_failed

Testing instructions

  • Add a product to the cart
  • As a registered WooPay user, initiate the OTP auth flow (make sure the OTP model shows up)
  • Open network tab in browser dev tools
  • Enter an invalid OTP code
  • Enter the correct OTP code
  • There should not be any admin-ajax requests with above event names under the tracksEventName field.
  • Repeat the tests using the WooPay button on cart and product pages
  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@malithsen malithsen marked this pull request as ready for review October 24, 2023 16:19
@malithsen malithsen requested review from a team and hsingyuc and removed request for a team October 24, 2023 16:20
@botwoo
Copy link
Collaborator

botwoo commented Oct 24, 2023 •
edited
Loading

Test the build

Option 1. Jetpack Beta

  • Install and activate Jetpack Beta.
  • Use this build by searching for PR number 7542 or branch name fix/remove-redundant-tracks-events in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

  • Latest commit: 4db0df6
  • Build time: 2023-10-24 17:08:19 UTC

Note: the build is updated when a new commit is pushed to this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Size Change: -831 B (0%)

Total Size: 1.43 MB

Filename Size Change
release/woocommerce-payments/dist/blocks-checkout.js 75.1 kB -76 B (0%)
release/woocommerce-payments/dist/checkout.js 28.9 kB -72 B (0%)
release/woocommerce-payments/dist/index.js 284 kB -47 B (0%)
release/woocommerce-payments/dist/multi-currency-switcher-block.js 60.2 kB -37 B (0%)
release/woocommerce-payments/dist/multi-currency.js 54.9 kB -36 B (0%)
release/woocommerce-payments/dist/order.js 41.1 kB -48 B (0%)
release/woocommerce-payments/dist/payment-gateways.js 38.6 kB -37 B (0%)
release/woocommerce-payments/dist/payment-request.js 13.1 kB -37 B (0%)
release/woocommerce-payments/dist/settings.js 234 kB -87 B (0%)
release/woocommerce-payments/dist/subscription-product-onboarding-modal.js 20.4 kB -40 B (0%)
release/woocommerce-payments/dist/subscriptions-empty-state.js 19.5 kB -42 B (0%)
release/woocommerce-payments/dist/tos.js 22 kB -38 B (0%)
release/woocommerce-payments/dist/upe_with_deferred_intent_creation_checkout.js 37 kB -57 B (0%)
release/woocommerce-payments/dist/upe-blocks-checkout.js 40.9 kB -39 B (0%)
release/woocommerce-payments/dist/upe-split-blocks-checkout.js 42.5 kB -41 B (0%)
release/woocommerce-payments/dist/woopay-express-button.js 52 kB -54 B (0%)
release/woocommerce-payments/dist/woopay.js 71.7 kB -43 B (0%)
ℹ️ View Unchanged
Filename Size
release/woocommerce-payments/assets/css/admin.css 1.04 kB
release/woocommerce-payments/assets/css/success.css 158 B
release/woocommerce-payments/dist/blocks-checkout-rtl.css 1.8 kB
release/woocommerce-payments/dist/blocks-checkout.css 1.8 kB
release/woocommerce-payments/dist/checkout-rtl.css 440 B
release/woocommerce-payments/dist/checkout.css 441 B
release/woocommerce-payments/dist/index-rtl.css 36.4 kB
release/woocommerce-payments/dist/index.css 36.5 kB
release/woocommerce-payments/dist/multi-currency-analytics.js 1.05 kB
release/woocommerce-payments/dist/multi-currency-rtl.css 2.88 kB
release/woocommerce-payments/dist/multi-currency.css 2.88 kB
release/woocommerce-payments/dist/order-rtl.css 676 B
release/woocommerce-payments/dist/order.css 679 B
release/woocommerce-payments/dist/payment-gateways-rtl.css 690 B
release/woocommerce-payments/dist/payment-gateways.css 692 B
release/woocommerce-payments/dist/payment-request-rtl.css 146 B
release/woocommerce-payments/dist/payment-request.css 146 B
release/woocommerce-payments/dist/product-details.js 898 B
release/woocommerce-payments/dist/settings-rtl.css 9.09 kB
release/woocommerce-payments/dist/settings.css 9.09 kB
release/woocommerce-payments/dist/subscription-edit-page.js 669 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css 519 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal.css 519 B
release/woocommerce-payments/dist/subscription-product-onboarding-toast.js 693 B
release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css 117 B
release/woocommerce-payments/dist/subscriptions-empty-state.css 117 B
release/woocommerce-payments/dist/tos-rtl.css 230 B
release/woocommerce-payments/dist/tos.css 231 B
release/woocommerce-payments/dist/upe_checkout-rtl.css 440 B
release/woocommerce-payments/dist/upe_checkout.css 441 B
release/woocommerce-payments/dist/upe_checkout.js 34.1 kB
release/woocommerce-payments/dist/upe_split_checkout-rtl.css 440 B
release/woocommerce-payments/dist/upe_split_checkout.css 441 B
release/woocommerce-payments/dist/upe_split_checkout.js 34.7 kB
release/woocommerce-payments/dist/upe-blocks-checkout-rtl.css 1.8 kB
release/woocommerce-payments/dist/upe-blocks-checkout.css 1.8 kB
release/woocommerce-payments/dist/upe-split-blocks-checkout-rtl.css 1.8 kB
release/woocommerce-payments/dist/upe-split-blocks-checkout.css 1.8 kB
release/woocommerce-payments/dist/woopay-express-button-rtl.css 146 B
release/woocommerce-payments/dist/woopay-express-button.css 146 B
release/woocommerce-payments/dist/woopay-rtl.css 3.91 kB
release/woocommerce-payments/dist/woopay.css 3.91 kB
release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css 622 B
release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js 814 B
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js 2.43 kB
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js 1.01 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js 522 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js 581 B
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js 160 B
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css 2.32 kB
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js 13.8 kB
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css 2.32 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css 1.2 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css 291 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css 403 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css 3.56 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css 299 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css 742 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css 572 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css 411 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js 544 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js 9.63 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js 6.8 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js 3.83 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js 544 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js 2.38 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js 22.1 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js 11.6 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js 1.29 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js 502 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js 355 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js 429 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js 1.38 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js 781 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js 1.1 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js 1.27 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css 392 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js 3.05 kB

compressed-size-action

@hsingyuc hsingyuc self-assigned this Oct 26, 2023
hsingyuc
hsingyuc approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@hsingyuc hsingyuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malithsen Thank you for working on this! I can see the tracks events by using the WooPay button on cart and product pages on develop and don't see the tracks events by using the WooPay button on cart and product pages on this branch. Tests are as expected and LGTM.

@malithsen malithsen added this pull request to the merge queue Oct 26, 2023
Merged via the queue into develop with commit 34c0175 Oct 26, 2023
27 checks passed
@malithsen malithsen deleted the fix/remove-redundant-tracks-events branch October 26, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsingyuc hsingyuc hsingyuc approved these changes

Assignees

@hsingyuc hsingyuc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malithsen @botwoo @hsingyuc