Fix date type in create payment intent response schema #7534

dpaun1985 · 2023-10-23T10:56:48Z

Fixes 286-gh-Automattic/woocommerce-payments-meta

Changes proposed in this Pull Request

Display formatted created date for payment intent endpoint.

Testing instructions

set the capture later option for the store
create an order
using get order API, get the order details ( GET /wp-json/wc/v3/orders/<order_id>)
using the create payment intent API, create a new payment intent for the order
URL: POST /wp-json/wc/v3/payments/payment_intents
Body:

{
   "payment_method":"pm_....",
   "customer":"cus_....",
   "order_id":"xxxxx"
}

check the response. created should be formatted instead of timestamp

Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Post merge

Link to testing instructions from release testing doc following these instructions : Add link here / 'QA Testing Not Applicable'
Add or update critical flows and testing instructions for critical flows, if applicable.
Add what's changed (description, screenshot, demo videos etc.) to the release announcement post, if applicable.

botwoo · 2023-10-23T11:02:27Z

Test the build

Option 1. Jetpack Beta

Install and activate Jetpack Beta.
Use this build by searching for PR number 7534 or branch name fix/date-type in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

Latest commit: d20839a
Build time: 2023-10-26 11:32:49 UTC

Note: the build is updated when a new commit is pushed to this PR.

github-actions · 2023-10-23T11:04:55Z

Size Change: 0 B

Total Size: 1.43 MB

ℹ️ View Unchanged

Filename	Size
`release/woocommerce-payments/assets/css/admin.css`	1.04 kB
`release/woocommerce-payments/assets/css/success.css`	158 B
`release/woocommerce-payments/dist/blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/blocks-checkout.js`	75.2 kB
`release/woocommerce-payments/dist/checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/checkout.css`	441 B
`release/woocommerce-payments/dist/checkout.js`	29 kB
`release/woocommerce-payments/dist/index-rtl.css`	36.4 kB
`release/woocommerce-payments/dist/index.css`	36.4 kB
`release/woocommerce-payments/dist/index.js`	284 kB
`release/woocommerce-payments/dist/multi-currency-analytics.js`	1.05 kB
`release/woocommerce-payments/dist/multi-currency-rtl.css`	2.88 kB
`release/woocommerce-payments/dist/multi-currency-switcher-block.js`	60.3 kB
`release/woocommerce-payments/dist/multi-currency.css`	2.88 kB
`release/woocommerce-payments/dist/multi-currency.js`	55 kB
`release/woocommerce-payments/dist/order-rtl.css`	676 B
`release/woocommerce-payments/dist/order.css`	679 B
`release/woocommerce-payments/dist/order.js`	41.1 kB
`release/woocommerce-payments/dist/payment-gateways-rtl.css`	690 B
`release/woocommerce-payments/dist/payment-gateways.css`	692 B
`release/woocommerce-payments/dist/payment-gateways.js`	38.6 kB
`release/woocommerce-payments/dist/payment-request-rtl.css`	153 B
`release/woocommerce-payments/dist/payment-request.css`	153 B
`release/woocommerce-payments/dist/payment-request.js`	13.2 kB
`release/woocommerce-payments/dist/product-details.js`	898 B
`release/woocommerce-payments/dist/settings-rtl.css`	9.05 kB
`release/woocommerce-payments/dist/settings.css`	9.05 kB
`release/woocommerce-payments/dist/settings.js`	234 kB
`release/woocommerce-payments/dist/subscription-edit-page.js`	669 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.css`	519 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.js`	20.4 kB
`release/woocommerce-payments/dist/subscription-product-onboarding-toast.js`	693 B
`release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.css`	117 B
`release/woocommerce-payments/dist/subscriptions-empty-state.js`	19.6 kB
`release/woocommerce-payments/dist/tos-rtl.css`	230 B
`release/woocommerce-payments/dist/tos.css`	231 B
`release/woocommerce-payments/dist/tos.js`	22 kB
`release/woocommerce-payments/dist/upe_checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/upe_checkout.css`	441 B
`release/woocommerce-payments/dist/upe_checkout.js`	34.1 kB
`release/woocommerce-payments/dist/upe_split_checkout-rtl.css`	440 B
`release/woocommerce-payments/dist/upe_split_checkout.css`	441 B
`release/woocommerce-payments/dist/upe_split_checkout.js`	34.7 kB
`release/woocommerce-payments/dist/upe_with_deferred_intent_creation_checkout.js`	37.1 kB
`release/woocommerce-payments/dist/upe-blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/upe-blocks-checkout.js`	41 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout-rtl.css`	1.8 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.css`	1.8 kB
`release/woocommerce-payments/dist/upe-split-blocks-checkout.js`	42.5 kB
`release/woocommerce-payments/dist/woopay-express-button-rtl.css`	153 B
`release/woocommerce-payments/dist/woopay-express-button.css`	153 B
`release/woocommerce-payments/dist/woopay-express-button.js`	52.1 kB
`release/woocommerce-payments/dist/woopay-rtl.css`	3.91 kB
`release/woocommerce-payments/dist/woopay.css`	3.91 kB
`release/woocommerce-payments/dist/woopay.js`	71.8 kB
`release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css`	622 B
`release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js`	814 B
`release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js`	2.43 kB
`release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js`	1.01 kB
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js`	522 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js`	581 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js`	160 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css`	2.32 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js`	13.8 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css`	2.32 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css`	1.2 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css`	291 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css`	403 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css`	3.56 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css`	299 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css`	742 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css`	572 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css`	411 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js`	9.63 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js`	6.8 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js`	3.83 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js`	544 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js`	2.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js`	22.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js`	11.6 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js`	1.29 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js`	502 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js`	355 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js`	429 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js`	1.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js`	781 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js`	1.1 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js`	1.27 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css`	392 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js`	3.05 kB

_{compressed-size-action}

elazzabi

Looks good, thank you for fixing!

mordeth

✅ LGTM!
❌ Changelog is missing!

…ments into fix/date-type

jessy-p

Would it be better to have a formatted string that makes sense to the merchant or user?
One example of a similar situation I could think of is

woocommerce-payments/includes/admin/class-wc-rest-payments-transactions-controller.php

Line 260 in dec5477

    
           private function format_transaction_date_with_timestamp( $transaction_date, $user_timezone ) {

dpaun1985 · 2023-10-24T13:23:15Z

Would it be better to have a formatted string that makes sense to the merchant or user? One example of a similar situation I could think of is

woocommerce-payments/includes/admin/class-wc-rest-payments-transactions-controller.php

Line 260 in dec5477

private function format_transaction_date_with_timestamp( $transaction_date, $user_timezone ) {

I made the changes. could you please re-check the changes. Thank you .

Fix date type in create payment intent response schema

53f5e20

dpaun1985 added the pr: needs review label Oct 23, 2023

dpaun1985 requested review from jessy-p and a team October 23, 2023 10:56

Merge branch 'develop' into fix/date-type

10f418a

elazzabi approved these changes Oct 23, 2023

View reviewed changes

mordeth approved these changes Oct 23, 2023

View reviewed changes

Dan Paun added 2 commits October 23, 2023 14:24

add chagelog

a968694

Merge branch 'fix/date-type' of github.com:Automattic/woocommerce-pay…

6c54ca6

…ments into fix/date-type

jessy-p reviewed Oct 23, 2023

View reviewed changes

Dan Paun and others added 2 commits October 24, 2023 16:00

Display formatted created date instead of timestamp

ae79e28

Merge branch 'develop' into fix/date-type

78e1c37

jessy-p approved these changes Oct 25, 2023

View reviewed changes

Merge branch 'develop' into fix/date-type

d20839a

dpaun1985 enabled auto-merge October 26, 2023 11:28

dpaun1985 added this pull request to the merge queue Oct 26, 2023

Merged via the queue into develop with commit bb99f81 Oct 26, 2023
27 checks passed

dpaun1985 deleted the fix/date-type branch October 26, 2023 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix date type in create payment intent response schema #7534

Fix date type in create payment intent response schema #7534

dpaun1985 commented Oct 23, 2023 •

edited

Loading

botwoo commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

elazzabi left a comment

mordeth left a comment •

edited

Loading

jessy-p left a comment •

edited

Loading

dpaun1985 commented Oct 24, 2023

Fix date type in create payment intent response schema #7534

Fix date type in create payment intent response schema #7534

Conversation

dpaun1985 commented Oct 23, 2023 • edited Loading

Changes proposed in this Pull Request

Testing instructions

botwoo commented Oct 23, 2023 • edited Loading

Test the build

Option 1. Jetpack Beta

Option 2. Jurassic Ninja - available for logged-in A12s

github-actions bot commented Oct 23, 2023 • edited Loading

elazzabi left a comment

Choose a reason for hiding this comment

mordeth left a comment • edited Loading

Choose a reason for hiding this comment

jessy-p left a comment • edited Loading

Choose a reason for hiding this comment

dpaun1985 commented Oct 24, 2023

dpaun1985 commented Oct 23, 2023 •

edited

Loading

botwoo commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited

Loading

mordeth left a comment •

edited

Loading

jessy-p left a comment •

edited

Loading