Fix - HPOS compatibility on Edit Order Screen #7527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2023 17:09
Reset buttons on Modals on Edit Order Page were not working in HPOS mode. Fixed by using the correct fields and added a workaround for core issue woocommerce/woocommerce#40871.
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +35 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
@jessy-p in case when I press cancel on the Modal, it does set it to cancelled on the current develop branch. However when I press do nothing, it set it to blank. Can you please check once?
https://github.com/Automattic/woocommerce-payments/assets/15019298/4c7a7dda-08b2-4af0-9adc-d82a9dba9aa0
Screen.Recording.2023-10-23.at.19.46.45.mov |
naman03malhotra
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7466
Changes proposed in this Pull Request
When HPOS is enabled, the order status should be fetched from
#original_order_statusand not#original_post_status.#original_order_statusvalue on HPOS order edit is not prefixed withwc-woocommerce/woocommerce#40871Ref: p1697706516222469-slack-C0E1AV8T0
Testing instructions
(Without the fix in this branch, the dropdown is not set correctly when user cancels the action)
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge