Add IE, DK, FI, NO, and SE to Klarna #7518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +49 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
kalessil
requested changes
Oct 19, 2023
There was a problem hiding this comment.
Can you please refer to your previous PR (https://github.com/Automattic/woocommerce-payments/pull/7282/files) and add the missing changes? Thanks!
|
@kalessil apologies, for the pre-mature request for review. While going though testing I noticed too that the JS config was missing countries. |
kalessil
approved these changes
Oct 19, 2023
|
@KarlisJ: no worries! Hope my writing didn't sound too pushy 😟 |
dmvrtx
approved these changes
Oct 19, 2023
|
I've tested with SE, IE. Will go through all, but have high confidence at this point. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Add IE, DK, FI, NO, and SE to Klarna payment method.
Additionally adds the related currency support and their limits.
Testing instructions
For each new country:
WooCommerce->settings->generalto domestic currency of that merchantcapability_klarna_payments = 1npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge