Deprecate Sofort #7480
Merged
Deprecate Sofort #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +261 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
… is not enabled (therefore only merchants who already enabled it will see it.
|
I spun up a JN site with this branch (using the link here) and am still seeing Sofort when going through the "Set up payments" task at WooCommerce > Home (
I'm not sure if this task is owned by WCPay or Woo core. |
|
Hey @csmcneill!
That's because that page belongs to WC Core. That fix is addressed by this core PR: woocommerce/woocommerce#40745 |
elizaan36
reviewed
Oct 17, 2023
|
Thanks @elizaan36! Good catch about using the 
|
…merce-payments into dev/sofort-deprecation
ismaeldcom
approved these changes
Oct 17, 2023
ismaeldcom
added
pr: ready to merge
and removed
pr: needs review
pr: needs design review
labels
|
LGTM! |
…merce-payments into dev/sofort-deprecation
…merce-payments into dev/sofort-deprecation
dmallory42
added a commit
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Ismael Martín Alabarce <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7490
Changes proposed in this Pull Request
Testing instructions
WCPay Onboarding Page
Payments- verify that the Sofort logo is not visible amongst the payment methods:NOTE: In order to test these steps, please also checkout the corresponding server/4029 PR. You may need to checkout
trunkon the server in order to request Sofort for the second part of the tests, then switch back to this branch.Payment Method Setup with Sofort disabled
In order to test this, please firstly checkout
trunkon the server, clear the cache, and check whether Sofort is enabled as a payment method and disable it if it is enabled. Then checkout the corresponding server PR and clear the account cache.Payments > Settingsand you should see Sofort not present in the payment methods list:WooCommerce > Settings > Paymentsand disable WooPayments on the menu. You should see the following confirmation modal. Verify that Sofort is not in the list:Payment Method Setup with Sofort disabled
In order to test this, please firstly checkout
trunkon the server and enable Sofort as a payment method inPayments > Settings. Then checkout the corresponding server branch again.Payments > Settings. Verify that you see the Notice under Sofort in the list:npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge