-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuthorizationRequired State #7471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job so far, here's my initial feedback:
…outEncryptionService
Thank you for the review. It really helped a lot. I have addressed all comments. Please let me know if there is anything to change or need additional feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction of this PR, great job adjusting it to the concept! 👏
There are only a couple of topics I'd like to run by you in comments. In the meantime, feel free to proceed with the PR:
- Basic checkout still works, but it would be nice to see the new
AuthenticationRequiredState
handled as well. - Psalm has a few errors, let's address them, and make sure that there are no left-over
@throws
in transition methods, especially withinInitialState
. - There are various unused
use
statements. Let's tidy up the code by removing them.
It might make sense to address as much as possible before starting to fix existing tests, and adding new ones, to avoid having to change fresh tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | ||
* The state, which indicates that the payment requires authentication (3DS). | ||
*/ | ||
class AuthenticationRequiredState extends AbstractPaymentState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on #7471 (comment):
class AuthenticationRequiredState extends AbstractPaymentState { | |
class PendingAuthenticationState extends AbstractPaymentState { |
tests/unit/src/Internal/Service/PaymentProcessingServiceTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Radoslav Georgiev <[email protected]>
fc03e6a
to
d62420c
Compare
This reverts commit f6abcee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for bearing with me through all the nitpicks :)
I love nitpicks 😃 Thank you for the extended review 🙇 |
Fixes #7418
Changes proposed in this Pull Request
This PR adds Authentication required state that handles the situation when payment needs to be authorized (3DS). Among others, this PR introduces multiple state changes.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge